New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,ddl: fix data race in TestCancel
#37926
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
TestCancel
TestCancel
Oops, there are more data race in this test. I'll fix them all, just wait a minute 😄 |
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8a8be33
|
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
I have also considered other solutions, for example using non-pointer receiver to implement the callback, so it can be copied automatically when passing into the functions. However, as this struct contains a
*BaseCallback
, it could cause more problem when misused.Issue Number: close #37757