Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: return right error when to get non-200 http code from pd #37982

Merged
merged 8 commits into from Sep 20, 2022
Merged

store: return right error when to get non-200 http code from pd #37982

merged 8 commits into from Sep 20, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 20, 2022 •
edited

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #37983

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
store: return right error when to get non-200 http code from pd
62d842c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2022
@hawkingrei
store: return right error when to get non-200 http code from pd
587a903 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
store: return right error when to get non-200 http code from pd
07efc49 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2022
@xhebox
Copy link
Contributor

xhebox commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 07efc49

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. do-not-merge/needs-triage-completed labels Sep 20, 2022
@hawkingrei
store: return right error when to get non-200 http code from pd
bb1dda9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
store: return right error when to get non-200 http code from pd
db75dab 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed do-not-merge/needs-triage-completed status/can-merge Indicates a PR has been approved by a committer. labels Sep 20, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db75dab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@hawkingrei
Copy link
Member Author

/run-build

@ti-chi-bot ti-chi-bot merged commit b5e17ad into pingcap:master Sep 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 21, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 52 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 22 min Existing failure
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 3 min 54 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 9 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 7 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return wrong error when TIDB GET http://{}:{}/tables/{}/{}/disk-usage
6 participants
@hawkingrei @ti-chi-bot @xhebox @sre-bot @tiancaiamao @tangenta