New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: update copr-cache admission for paging and initial copr task's paging size #38012
Conversation
…ask's paging size
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2c5053b
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.3 in PR #38077 |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #37768 #37974
Problem Summary:
What is changed and how it works?
I figure out that for Q17, the root cause of the issue is copr-cache #37768 (comment)
When paging is disabled, the copr cache admission check would check the copr request data size < 10M
When paging is enable, this check become useless because the data is much smaller.
I add a
pagingTaskIdx
and check ifpagingTaskIdx
is large, don't cache the data.Check List
Tests
I'll run the TPCH bench bot to verify the change work.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.