Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix issue of drop database with foreign key failed #38053

Merged
merged 7 commits into from Sep 21, 2022
Merged

*: fix issue of drop database with foreign key failed #38053

merged 7 commits into from Sep 21, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #38051

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
*: fix issue of drop database with foreign key failed
925607e 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine error msg
cf6ca75 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2022
@crazycs520
Copy link
Contributor Author

/run-common-test
/run-integration-ddl-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@tangenta tangenta mentioned this pull request Sep 21, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2022
@crazycs520
Copy link
Contributor Author

/merge

1 similar comment
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d8cbd1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@crazycs520
Copy link
Contributor Author

/run-common-test
/run-integration-ddl-test

@hawkingrei
Copy link
Member

/run-build

@crazycs520
Copy link
Contributor Author

/run-common-test
/run-integration-ddl-test

@hawkingrei
Copy link
Member

/run-integration-ddl-test

@crazycs520
Copy link
Contributor Author

/merge

@crazycs520
Copy link
Contributor Author

/run-all-tests
/merge

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit ba25fd5 into pingcap:master Sep 21, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2022
Closed
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 21, 2022
@crazycs520 @ti-srebot
cherry pick pingcap#38053 to release-6.3
5af29b8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.3 in PR #38066

crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 21, 2022
@crazycs520
Revert "cherry pick pingcap#38053 to release-6.3"
bb22753 
This reverts commit 5af29b8.
@sre-bot
Copy link
Contributor

sre-bot commented Sep 21, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 36, total 37 25 min New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 52 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 23 min Existing failure
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 5 min 44 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 9 min 28 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.3-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue of drop database with foreign key
6 participants
@crazycs520 @ti-chi-bot @hawkingrei @ti-srebot @sre-bot @tangenta