New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: enable region load balance for MPP #38117
copr: enable region load balance for MPP #38117
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev |
b1f2065
to
cd04fb4
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cd04fb40fd37ff5b3f4ec3d1e31f2964ea0e010a
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: daea317a9f8de617787a24499bded38d221478f3
|
/run-unit-test |
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
757ed87
to
d2830fb
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e9c1447
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: xufei xufeixw@mail.ustc.edu.cn
What problem does this PR solve?
Issue Number: close #38113
Problem Summary:
The whole story is like this:
loadBalance
to false in here.)select * from t
, assuming the cluster has 2 TiFlash nodes,t
has two TiFlash replica, and t contans 100 regions, it is possible that the query only access the regions from one TiFlash node, the other TiFlash node is completely ignoredselect * from t
, the cluster has 2 TiFlash nodes,t
has two TiFlash replica, this time assuming t only contains 1 region, and the query concurrency is 100, then it is possible that all the 100 queries read from one TiFlash node.balanceBatchCopTask
, it will balance the region access between different TiFlash's node for each query.live
node.So, as we can see, due to disable per region's load balance, BatchCop/MPP still suffer from inter-query's unbalance preblem. But for MPP request, there is no
unavailable node
problems, we actually do not need disable per region's load balance. This pr enable per region's load balance for MPP request.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.