Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: better error message for ADMIN CHECK INDEX #38298

Merged
merged 2 commits into from Oct 11, 2022
Merged

executor: better error message for ADMIN CHECK INDEX #38298

merged 2 commits into from Oct 11, 2022

Conversation

taofengliu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #37323

Problem Summary:

What is changed and how it works?

Maybe the better error message should be "index primary is not defined in table %v when primary key is a single integer column and clustered" ?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 4, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @taofengliu!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2022
@taofengliu
Copy link
Contributor Author

/cc @bb7133

@ti-chi-bot ti-chi-bot requested a review from bb7133 October 8, 2022 02:31
@taofengliu
Copy link
Contributor Author

@bb7133 Could you please review this PR?

@taofengliu
Copy link
Contributor Author

/cc @CbcWestwolf

CbcWestwolf
CbcWestwolf reviewed Oct 9, 2022
View reviewed changes
Copy link
Member

@CbcWestwolf CbcWestwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :-)
Could you please add more unit tests in proper functions in https://github.com/pingcap/tidb/blob/master/executor/admin_test.go? It is better if the added test cases cover all potential introduced paths in this PR, which are some illegal admin check/admin recover/admin cleanup statements.

@taofengliu
Copy link
Contributor Author

Thanks for your contribution! :-) Could you please add more unit tests in proper functions in https://github.com/pingcap/tidb/blob/master/executor/admin_test.go? It is better if the added test cases cover all potential introduced paths in this PR, which are some illegal admin check/admin recover/admin cleanup statements.

OK, I will add tests.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2022
@CbcWestwolf
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@taofengliu
Copy link
Contributor Author

Thanks so much for reviewing this PR! @CbcWestwolf
Because first-time contributors need a maintainer to approve running workflows, could you please address this then this PR can be merged.

@CbcWestwolf
Copy link
Member

could you please address this then this PR can be merged.

Sure! I'll look for someone for help.

@CbcWestwolf
Copy link
Member

/cc tangenta
PTAL

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2022
@taofengliu taofengliu requested review from tangenta and removed request for bb7133 October 10, 2022 12:43
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2022
@ti-chi-bot
Copy link
Member

@taofengliu: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@taofengliu
Copy link
Contributor Author

/assign @hawkingrei

@tangenta tangenta changed the title *: better error message for ADMIN CHECK/RECOVER/CLEANUP INDEX (#37323) executor: better error message for ADMIN CHECK INDEX Oct 11, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c56d05b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2022
@ti-chi-bot ti-chi-bot merged commit 6a9da0f into pingcap:master Oct 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 5 min 42 sec Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 13 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 15 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@taofengliu taofengliu deleted the #37323 branch October 11, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@hawkingrei hawkingrei

Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*: better error message for ADMIN CHECK/RECOVER/CLEANUP INDEX
6 participants
@taofengliu @ti-chi-bot @CbcWestwolf @tangenta @sre-bot @hawkingrei