Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore: ignore error when downstream db/table is created #38327

Merged
merged 11 commits into from Oct 12, 2022
Merged

restore: ignore error when downstream db/table is created #38327

merged 11 commits into from Oct 12, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Oct 8, 2022 •
edited

What problem does this PR solve?

Issue Number: ref #37984

Problem Summary:

What is changed and how it works?

When CREATE DATABASE or CREATE TABLE meet error, check if the target is already exists at lightning side to avoid parsing error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2022
@lance6716
add lightning task config
358d7a6 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
finish IT
1aa0aed 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add code
62a494b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2022
@lance6716
wip
c490524 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
wip2
c9c5a2e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add another test
191aa1b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]restore: ignore error when downstream db/table is created restore: ignore error when downstream db/table is created Oct 8, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2022
@lance6716
Copy link
Contributor Author

/cc @D3Hunter @gozssky

@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716 lance6716 added the component/lightning This issue is related to Lightning of TiDB. label Oct 8, 2022
@lance6716
Copy link
Contributor Author

/run-integration-br-test

2 similar comments
@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716
address comment
a6fafec 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Merge branch 'master' into if-not-exists
2e89ab2
@lance6716
address comment
2cd6974 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@lance6716
Copy link
Contributor Author

/cc @D3Hunter @buchuitoudegou PTAL

@ti-chi-bot
Copy link
Member

@lance6716: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @D3Hunter @buchuitoudegou PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor Author

ptal @D3Hunter @buchuitoudegou

@lance6716
Copy link
Contributor Author

/run-integration-br-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2022
lichunzhu
lichunzhu approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cd6974

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2022
@ti-chi-bot ti-chi-bot merged commit 00791e7 into pingcap:master Oct 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 30 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 8 min 54 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 13 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 44 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@sleepymole sleepymole sleepymole approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lance6716 @ti-chi-bot @sre-bot @D3Hunter @sleepymole @lichunzhu