New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: keep progress in information_schema.tiflash_replica two digits after the decimal point #38415
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hehechen <awd123456sss@gmail.com>
722c389
to
d40b28b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/assign @breezewish |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 30ee7bd
|
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
Signed-off-by: hehechen awd123456sss@gmail.com
What problem does this PR solve?
Issue Number: close #38412
Problem Summary:
For partitioned tables, progress in information_schema.tiflash_replica does not limit the number of digits after the decimal point. It's better to keep the same with non-partitioned tables and keep two digits after the decimal point.
What is changed and how it works?
Check List
Tests
BR restore partition table with TiFlash replica.
Before modified:
After modified:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.