Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: init tidb new extension framework #38497

Merged
merged 17 commits into from Oct 19, 2022
Merged

extension: init tidb new extension framework #38497

merged 17 commits into from Oct 19, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #38496

What is changed and how it works?

Init a new framework to allow other package to "register" extension to tidb, for example:

extension.Register("custom", extension.WithCustomDynPrivs([]string{"priv1", "priv2"}))

The extension can register it's own dynamic privileges or system variables. We'll provide more options later to make extension to extend tidb's function easily.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2022
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

/run-build

@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

2 similar comments
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@hawkingrei
Copy link
Member

/run-check_dev_2

wuhuizuo added a commit to PingCAP-QE/ci that referenced this pull request Oct 17, 2022
@wuhuizuo
fix(pipelines/pingcap/tidb): ram limit and other args for bazel build
a462533 
why:
occued bazel build OOM in `ghpr_check2` builds for pingcap/tidb#38497

what:
same as pod of `ghpr_build`, add ram limit args to the bazel RC file.
@wuhuizuo wuhuizuo mentioned this pull request Oct 17, 2022
Merged
wuhuizuo added a commit to PingCAP-QE/ci that referenced this pull request Oct 17, 2022
@wuhuizuo
fix(pipelines/pingcap/tidb): ram limit and other args for bazel build (…
28ac492 
…#1477)

why:
occued bazel build OOM in `ghpr_check2` builds for pingcap/tidb#38497

what:
same as pod of `ghpr_build`, add ram limit args to the bazel RC file.
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@hawkingrei
Copy link
Member

/run-check_dev_2

@hawkingrei
Copy link
Member

/run-all-tests

@hawkingrei
Copy link
Member

/run-all-tests

@hawkingrei
Copy link
Member

/run-check_dev_2

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

bb7133
bb7133 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2022
@bb7133
Copy link
Member

bb7133 commented Oct 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c21aa87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2022
@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

/rebuild

3 similar comments
@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/run-build

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eee6614

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@ti-chi-bot ti-chi-bot merged commit 93e0d36 into pingcap:master Oct 19, 2022
@lcwangchao lcwangchao deleted the extension_init branch October 19, 2022 13:17
@sre-bot
Copy link
Contributor

sre-bot commented Oct 19, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 24 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 56 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 47 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 26 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox xhebox approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init the new extension framework
6 participants
@lcwangchao @ti-chi-bot @hawkingrei @bb7133 @sre-bot @xhebox