ddl: Add lower limit of length of index column type #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Jul 24, 2017
| @@ -49,6 +49,10 @@ func buildIndexColumns(columns []*model.ColumnInfo, idxColNames []*ast.IndexColN | |||
| return nil, errKeyColumnDoesNotExits.Gen("column does not exist: %s", ic.Column.Name) | |||
| } | |||
|
|
|||
| if col.Flen == 0 { | |||
There was a problem hiding this comment.
We should check this in plan/validator.go.
There was a problem hiding this comment.
How to check table column type length in create index grammar?
There was a problem hiding this comment.
You can check the Flen in this function:https://github.com/pingcap/tidb/blob/master/plan/validator.go#L259
Refer to this as an example.
There was a problem hiding this comment.
A statement as create index idx on t (i) will not pass table column type, it is not the same case of create table statement.
jackysp
changed the title
|
LGTM |
|
@tiancaiamao @zimulala PTAL |
zimulala
approved these changes
Jul 25, 2017
|
LGTM |
zimulala
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3833 . @zimulala @hicqu PTAL