Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix panic cause by concurrent map iteration and write in memory usage alarm #38729

Merged
merged 8 commits into from Nov 2, 2022
Merged

util: fix panic cause by concurrent map iteration and write in memory usage alarm #38729

merged 8 commits into from Nov 2, 2022

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Oct 28, 2022 •
edited

What problem does this PR solve?

Issue Number: close #38703

Problem Summary:

What is changed and how it works?

Fix panic cause by concurrent map iteration and write in memory usage alarm.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix panic cause by concurrent map iteration and write in memory usage alarm.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Oct 28, 2022
@mengxin9014 mengxin9014 marked this pull request as draft October 28, 2022 10:47
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2022
@mengxin9014 mengxin9014 marked this pull request as ready for review October 31, 2022 08:58
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Nov 1, 2022
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b83be6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit ba175c4 into pingcap:master Nov 2, 2022
@mengxin9014
Copy link
Contributor Author

/rebuild

@mengxin9014 mengxin9014 deleted the mx/fixPanicByConcurrentMapIterationAndWriteInMemoryUsageAlarm branch November 2, 2022 06:29
@sre-bot
Copy link
Contributor

sre-bot commented Nov 2, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 31 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 15 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 26 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

mengxin9014 added a commit to mengxin9014/tidb that referenced this pull request Nov 12, 2022
@mengxin9014
Revert "util: fix panic cause by concurrent map iteration and write i…
9eb5f37 
…n memory usage alarm (pingcap#38729)"

This reverts commit ba175c4.
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 13, 2022
@mengxin9014 @ti-chi-bot
Revert "util: fix panic cause by concurrent map iteration and write i…
14cff3b 
…n memory usage alarm (pingcap#38729)"

This reverts commit ba175c4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb occurred fatal error: concurrent map iteration and map write when memory grow quickly
5 participants
@mengxin9014 @ti-chi-bot @XuHuaiyu @sre-bot @hawkingrei