Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add foreign key check/cascade runtime stats information in explain analyze result #39203

Merged
merged 55 commits into from Nov 30, 2022

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 16, 2022

What problem does this PR solve?

Merge #39167 first.

Issue Number: close #39202

Problem Summary: Add execution runtime stats for foreign key check/cascade

prepare:

set @@global.tidb_enable_foreign_key=1;
set @@foreign_key_checks=1;
create table t1 (id int key);
create table t2 (id int key, foreign key fk(id) references t1(id) ON UPDATE CASCADE ON DELETE CASCADE);
insert into t1 values (1),(2),(3),(4),(5),(6),(7),(8),(9),(10);

Here is some explain analyze results:

test2> explain analyze insert into t2 values (1);
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------+-----------------------------+----------+------+
| id                    | estRows | actRows | task | access object | execution info                                          | operator info               | memory   | disk |
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------+-----------------------------+----------+------+
| Insert_1              | N/A     | 0       | root |               | time:97µs, loops:1, prepare: 28.8µs, insert:68.3µs      | N/A                         | 97 Bytes | N/A  |
| └─Foreign_Key_Check_3 | 0.00    | 0       | root | table:t1      | total:163.5µs, check:151µs, lock:12.4µs, foreign_keys:1 | foreign_key:fk, check_exist | N/A      | N/A  |
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------+-----------------------------+----------+------+
2 rows in set
Time: 0.012s
test2> explain analyze update t2 set id=id+1 where id = 1;
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------------------------------------------------+-----------------------------+-----------+------+
| id                    | estRows | actRows | task | access object | execution info                                                                                    | operator info               | memory    | disk |
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------------------------------------------------+-----------------------------+-----------+------+
| Update_3              | N/A     | 0       | root |               | time:240.8µs, loops:1, Get:{num_rpc:1, total_time:14.3µs},BatchGet:{num_rpc:1, total_time:11.3µs} | N/A                         | 380 Bytes | N/A  |
| ├─Point_Get_1         | 1.00    | 1       | root | table:t2      | time:82.2µs, loops:2, Get:{num_rpc:1, total_time:36.1µs}                                          | handle:1                    | N/A       | N/A  |
| └─Foreign_Key_Check_4 | 0.00    | 0       | root | table:t1      | total:49.2µs, check:39µs, lock:10.2µs, foreign_keys:1                                             | foreign_key:fk, check_exist | N/A       | N/A  |
+-----------------------+---------+---------+------+---------------+---------------------------------------------------------------------------------------------------+-----------------------------+-----------+------+
3 rows in set
Time: 0.006s
test2> explain analyze delete from t1 where id > 1;
+-------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------+-----------+------+
| id                      | estRows | actRows | task      | access object | execution info                                                                                                                                        | operator info                                             | memory    | disk |
+-------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------+-----------+------+
| Delete_4                | N/A     | 0       | root      |               | time:373.3µs, loops:1                                                                                                                                 | N/A                                                       | 551 Bytes | N/A  |
| ├─TableReader_7         | 3333.33 | 9       | root      |               | time:319µs, loops:2, cop_task: {num: 1, max: 256µs, proc_keys: 0, rpc_num: 1, rpc_time: 229.5µs, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15} | data:TableRangeScan_6                                     | 250 Bytes | N/A  |
| │ └─TableRangeScan_6    | 3333.33 | 9       | cop[tikv] | table:t1      | tikv_task:{time:211.4µs, loops:0}                                                                                                                     | range:(1,+inf], keep order:false, stats:pseudo            | N/A       | N/A  |
| └─Foreign_Key_Cascade_8 | 0.00    | 0       | root      | table:t2      | total:92.8µs, foreign_keys:9                                                                                                                          | foreign_key:fk, on_delete:CASCADE                         | N/A       | N/A  |
|   └─Delete_10           | N/A     | 0       | root      |               | time:54.8µs, loops:1                                                                                                                                  | N/A                                                       | 213 Bytes | N/A  |
|     └─Batch_Point_Get_9 | 9.00    | 1       | root      | table:t2      | time:50.7µs, loops:2, BatchGet:{num_rpc:1, total_time:26µs}                                                                                           | handle:[2 3 4 5 6 7 8 9 10], keep order:false, desc:false | N/A       | N/A  |
+-------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------+-----------+------+
6 rows in set
Time: 0.006s
test2> explain analyze update t1 set id=id+1 where id = 1;
+---------------------------+---------+---------+------+---------------+---------------------------------------------------------------+------------------------------------------+-----------+------+
| id                        | estRows | actRows | task | access object | execution info                                                | operator info                            | memory    | disk |
+---------------------------+---------+---------+------+---------------+---------------------------------------------------------------+------------------------------------------+-----------+------+
| Update_3                  | N/A     | 0       | root |               | time:69.6µs, loops:1, Get:{num_rpc:1, total_time:1.5µs}       | N/A                                      | 194 Bytes | N/A  |
| ├─Point_Get_1             | 1.00    | 1       | root | table:t1      | time:28.8µs, loops:2, Get:{num_rpc:1, total_time:12µs}        | handle:1                                 | N/A       | N/A  |
| └─Foreign_Key_Cascade_4   | 0.00    | 0       | root | table:t2      | total:45.7µs, foreign_keys:1                                  | foreign_key:fk, on_update:CASCADE        | N/A       | N/A  |
|   └─Update_7              | N/A     | 0       | root |               | time:13.5µs, loops:1                                          | N/A                                      | 0 Bytes   | N/A  |
|     ├─Batch_Point_Get_5   | 1.00    | 0       | root | table:t2      | time:12.8µs, loops:1, BatchGet:{num_rpc:1, total_time:3.58µs} | handle:[1], keep order:false, desc:false | N/A       | N/A  |
|     └─Foreign_Key_Check_8 | 0.00    | 0       | root | table:t1      | total:0s                                                      | foreign_key:fk, check_exist              | N/A       | N/A  |
+---------------------------+---------+---------+------+---------------+---------------------------------------------------------------+------------------------------------------+-----------+------+
6 rows in set

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 16, 2022
crazycs520 and others added 13 commits November 17, 2022 14:42
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-mysql-test

@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fd22612

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 63ce793 into pingcap:master Nov 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 21 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 50 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain analyze DML should contain foreign key check/cascade information
7 participants