Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: fix outdated time shift for variable with TypeTime #39720

Merged
merged 6 commits into from Dec 8, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 7, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #39719

Problem Summary:

The time shift for a time zone can differ in the history. For example, Asia/Shanghai is +0805 in the history. If the user set variable without timezone, and TiDB equipped it with local time zone by default. It'll result in an unexpected behavior.

What is changed and how it works?

Use the now year, month and day. Actually any near enough date is fine (as the timezone shift doesn't change frequently, right?). I still use the current date to make it more robust.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that setting time variables (for example, `tidb_auto_analyze_start_time`) without explicit timezone will give an outdated time shift.

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao requested a review from a team as a code owner December 7, 2022 09:24
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 7, 2022

/run-check-issue-triage-complete

@YangKeao
Copy link
Member Author

YangKeao commented Dec 7, 2022

/run-mysql-test

@YangKeao
Copy link
Member Author

YangKeao commented Dec 7, 2022

/run-mysql-test

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Dec 8, 2022

/run-unit-test

@YangKeao
Copy link
Member Author

YangKeao commented Dec 8, 2022

@xhebox @mjonss Could you help me to merge this PR?

@xhebox
Copy link
Contributor

xhebox commented Dec 8, 2022

@xhebox @mjonss Could you help me to merge this PR?

You need an approve from configuration owner. I just approved the PR so that they don't need to review again. /cc @bb7133

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b32c29e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@ti-chi-bot
Copy link
Member

@YangKeao: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeTime variable is incorrect for timezone whose shift is different in history
6 participants