New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: ignore Preprocess error for the prefetchPointPlanKeys
optimization
#39945
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
What if there is some other kind of error we can not ignore? |
If other kinds of error happen, we just bypass this optimization. Bypass this optimization is always safe. |
PTAL @jackysp |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 194d26c
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #39664
Problem Summary:
What is changed and how it works?
The error is throw from the
Preprocess()
in theprefetchPointPlanKeys
.prefetchPointPlanKeys
is quite tricky, it does not reuse the common code path for the sake of performance.Premature optimization is the root of all evil.
This tricky optimization helped us improve the performance by 100 times and won the deal, and now it's time to pay the (technical) debt.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.