Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: ignore Preprocess error for the prefetchPointPlanKeys optimization #39945

Merged
merged 1 commit into from Apr 14, 2023

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 14, 2022

What problem does this PR solve?

Issue Number: close #39664

Problem Summary:

What is changed and how it works?

The error is throw from the Preprocess() in the prefetchPointPlanKeys.
prefetchPointPlanKeys is quite tricky, it does not reuse the common code path for the sake of performance.

Premature optimization is the root of all evil.
This tricky optimization helped us improve the performance by 100 times and won the deal, and now it's time to pay the (technical) debt.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2022
@dveeden
Copy link
Contributor

dveeden commented Mar 23, 2023

@jackysp @coocood looks like this PR is pending on your review?

@coocood
Copy link
Member

coocood commented Mar 24, 2023

What if there is some other kind of error we can not ignore?

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Mar 24, 2023

What if there is some other kind of error we can not ignore?

If other kinds of error happen, we just bypass this optimization. Bypass this optimization is always safe.
Maybe the query would get error again when it execute later, whatever, it's safe to get the expected result and fix weird errors like #39664

@coocood

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@tiancaiamao
Copy link
Contributor Author

PTAL @jackysp

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2023
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 194d26c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2023
@ti-chi-bot ti-chi-bot merged commit 464fb18 into pingcap:master Apr 14, 2023
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #43056.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #43057.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43058.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43059.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming a table inside a transaction and using it doesn't work
5 participants