Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support set resource-group-name for kv request #40237

Merged
merged 12 commits into from Jan 13, 2023
Merged

executor: support set resource-group-name for kv request #40237

merged 12 commits into from Jan 13, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Dec 29, 2022 •
edited

What problem does this PR solve?

Issue Number: Ref #38825

Problem Summary:

What is changed and how it works?

Set the ResourceGroupName parameter for foreground read and write kv request so the scheduler at tikv side can handle these reqeusts according to resource group settings.

NOTE: the resource group name of tasks trigger by DDL or background jobs maybe not be set correctly currently. We will do it in following PR after it is clear what resource group we should bind for these tasks.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2022
@glorv
Copy link
Contributor Author

glorv commented Dec 29, 2022

depend on tikv/client-go#650

@glorv glorv changed the title txn,executor: support set resource-group-name for kv request executor: support set resource-group-name for kv request Dec 29, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2023
@glorv glorv marked this pull request as ready for review January 9, 2023 09:15
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2023
@glorv
Copy link
Contributor Author

glorv commented Jan 9, 2023

@BornChanger @Connor1996 PTAL

Connor1996
Connor1996 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@Connor1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2023
@glorv
Copy link
Contributor Author

glorv commented Jan 12, 2023

@qw4990 Could you please take a look?

@BornChanger BornChanger mentioned this pull request Jan 12, 2023
Merged
3 tasks
BornChanger
BornChanger reviewed Jan 12, 2023
View reviewed changes
distsql/request_builder.go
@@ -290,6 +291,7 @@ func (builder *RequestBuilder) SetFromSessionVars(sv *variable.SessionVars) *Req
builder.RequestSource.RequestSourceInternal = sv.InRestrictedSQL
builder.RequestSource.RequestSourceType = sv.RequestSourceType
builder.StoreBatchSize = sv.StoreBatchSize
builder.Request.ResourceGroupName = sv.ResourceGroupName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the global flag @@global.tidb_enable_resource_control here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing, we are going to set default resource group name in initializing session context, so no need to check here.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
@glorv
Copy link
Contributor Author

glorv commented Jan 12, 2023

@tiancaiamao PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 13, 2023
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2dc8338

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
@ti-chi-bot
Copy link
Member

@glorv: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 17c0d54 into pingcap:master Jan 13, 2023
@glorv glorv deleted the resource-group-name branch January 13, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@nolouch nolouch nolouch approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glorv @ti-chi-bot @tiancaiamao @nolouch @Connor1996 @BornChanger