Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: add timeout for updateStatsWorker exit process #40434

Merged
merged 28 commits into from Jan 12, 2023
Merged

domain: add timeout for updateStatsWorker exit process #40434

merged 28 commits into from Jan 12, 2023

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jan 9, 2023 •
edited

What problem does this PR solve?

Issue Number: ref #40433

Problem Summary:

What is changed and how it works?

add timeout for updateStatsWorker exit process and revise log for stats background worker

Check List

Tests

  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 9, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-cherry-pick-release-6.5 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2023
@Yisaer Yisaer marked this pull request as ready for review January 10, 2023 06:22
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2023
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 10, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a3de6d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 12, 2023

/run-all-tests

@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 12, 2023

/retest-required

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 12, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c74d76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 22b43ff into pingcap:master Jan 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2023
Open
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #40530.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 12, 2023
@Yisaer @ti-chi-bot
This is an automated cherry-pick of pingcap#40434
30f0166 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Yisaer @ti-chi-bot @hawkingrei @qw4990