Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: use identifier as user's resource group name #40479

Merged
merged 9 commits into from Jan 12, 2023
Merged

parser: use identifier as user's resource group name #40479

merged 9 commits into from Jan 12, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jan 10, 2023 •
edited

Signed-off-by: BornChanger dawn_catcher@126.com

What problem does this PR solve?

Issue Number: ref #38825

Problem Summary:

What is changed and how it works?

This pr addressed 2 parser problems related to resource group

  1. Use identifier instead of strLiteral to make user dcl statement easier
  2. Fix the drop resource group statement issue

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@BornChanger
parser: use identifier as user's resource group name and also fix a d…
37aa3a8 
…rop resource group bug

Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2023
@BornChanger
Copy link
Contributor Author

/cc @nolouch @glorv

@BornChanger BornChanger changed the title parser: use identifier as user's resource group name and also fix a d… parser: use identifier as user's resource group name Jan 10, 2023
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
executor: fix case
5651790 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/cc @tiancaiamao

@BornChanger
*: format parser.y
1518780 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2023
glorv
glorv reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

parser/parser_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 12, 2023
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1518780

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@glorv
Copy link
Contributor

glorv commented Jan 12, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@BornChanger
*: fix store function of resource group
747cfb2 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@glorv
Copy link
Contributor

glorv commented Jan 12, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@glorv
Copy link
Contributor

glorv commented Jan 12, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 747cfb2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@ti-chi-bot
Copy link
Member

@BornChanger: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit df019ae into pingcap:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BornChanger @ti-chi-bot @tiancaiamao @glorv @nolouch