Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain, tidb-server: stop launching new auto analyze job when shutting down #41346

Merged
merged 1 commit into from Feb 14, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41318

Problem Summary:

What is changed and how it works?

When shutting down, stop autoAnalyzeWorker from launching new auto analyze job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
set @@global.tidb_enable_auto_analyze = 0; 
create table t1(a int, b int);
create table t2(a int, b int);
-- insert data into t1 and t2 to let them be ready for triggering auto analyze
set @@global.tidb_enable_auto_analyze = 1; 

Assume auto analyze of t1 is triggered. Then Ctrl+C to shut down the tidb server. Auto analyze of t1 is killed. Before the PR, auto analyze of t2 may be triggered(I add time.Sleep in cleanup to make that reproducible). After the PR, auto analyze of t2 would not be triggered.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@xuyifangreeneyes xuyifangreeneyes added affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 and removed do-not-merge/needs-triage-completed labels Feb 14, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 labels Feb 14, 2023
@xuyifangreeneyes
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 87b8330

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit af7fe50 into pingcap:master Feb 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #41387.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41389.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41391.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41392.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
nolouch pushed a commit to nolouch/tidb that referenced this pull request Jul 13, 2023
…shutting down (pingcap#476)

* test for small ttl of etcd key

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* domain, tidb-server: stop launching new auto analyze job when shutting down (pingcap#41346)

close pingcap#41318

* clean other change

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

---------

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Co-authored-by: Yifan Xu <30385241+xuyifangreeneyes@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after restart one tidb,this tidb start after 30min
4 participants