Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add missing CanExprsPushDown checks when generating IndexMerge path for or #41361

Merged
merged 1 commit into from Feb 14, 2023
Merged

planner: add missing CanExprsPushDown checks when generating IndexMerge path for or #41361

merged 1 commit into from Feb 14, 2023

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Feb 13, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41273 close #41293

Problem Summary:

This bug is introduced by #30341.

This case is related to the SET type mainly. We don't support pushing down the SET type now. util/ranger also can't correctly handle expressions on SET column. So it requires these expressions be blocked in advance. After #30341, such expressions can reach util/ranger without the CanExprsPushDown check.

What is changed and how it works?

Add a CanExprsPushDown check before using an expression to build an IndexMerge partial path.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fixdb
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2023
fixdb
fixdb approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

planner/core/indexmerge_path.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@qw4990
Copy link
Contributor

qw4990 commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 06a5ce2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
guo-shaoge
guo-shaoge reviewed Feb 14, 2023
View reviewed changes
planner/core/integration_test.go
expectedRes := []string{"ir1z,f1,e6yd d 13mdezixgcn", "ir1z,f1,e6yd i71o 13mdezixgcn", "nwbk 8ue 13mdezixgcn"}
tk.MustQuery("select * from t where a between 'e6yd' and 'z' or b <> '8ue';").Sort().Check(testkit.Rows(expectedRes...))
tk.MustQuery("select /*+ use_index_merge(t) */ * from t where a between 'e6yd' and 'z' or b <> '8ue';").Sort().Check(testkit.Rows(expectedRes...))
// For now tidb doesn't support push set type to TiKV, and column a is a set type, so we shouldn't generate a IndexMerge path.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need add some log or warning to indicate why cannot use index merge ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would print a general warning "IndexMerge is inapplicable" like other cases when we failed to generate an IndexMerge path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if it could print the particular reason. But we also don't print the reason in other cases, so I think it's unnecessary to add it in this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ti-chi-bot ti-chi-bot merged commit 74875da into pingcap:master Feb 14, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 14, 2023
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41395.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
@time-and-fate @ti-chi-bot
This is an automated cherry-pick of pingcap#41361
3385d88 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 14, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41396.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
@time-and-fate @ti-chi-bot
This is an automated cherry-pick of pingcap#41361
998088a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 14, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41397.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 14, 2023
@time-and-fate @ti-chi-bot
This is an automated cherry-pick of pingcap#41361
7dfabca 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 14, 2023
@ti-chi-bot
planner: add missing CanExprsPushDown checks when generating IndexM…
1b9e79c 
…erge path for `or` (#41361) (#41397)

close #41273, close #41293
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@time-and-fate @blacktear23
planner: add missing CanExprsPushDown checks when generating IndexM…
9bfee2b 
…erge path for `or` (pingcap#41361)

close pingcap#41273, close pingcap#41293
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@time-and-fate @ghazalfamilyusa
planner: add missing CanExprsPushDown checks when generating IndexM…
e7a302f 
…erge path for `or` (pingcap#41361)

close pingcap#41273, close pingcap#41293
ti-chi-bot added a commit that referenced this pull request Mar 29, 2023
@ti-chi-bot
planner: add missing CanExprsPushDown checks when generating IndexM…
aac228a 
…erge path for `or` (#41361) (#41396)

close #41273, close #41293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge left review comments

@fixdb fixdb fixdb approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index merge got wrong result Inconsistent result of the same queries, related to index merge, null
5 participants
@time-and-fate @ti-chi-bot @qw4990 @fixdb @guo-shaoge