Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more checks when pushing TopN down #41370

Merged
merged 12 commits into from Feb 15, 2023
Merged

planner: add more checks when pushing TopN down #41370

merged 12 commits into from Feb 15, 2023

Conversation

Dousir9
Copy link
Contributor

@Dousir9 Dousir9 commented Feb 14, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41355

Problem Summary:

What is changed and how it works?

  1. TopN should not be pushed down to TiFlash/TiKV if TopN.ByItems contains virtually generated columns.
  2. The "virtually generated column" push down is not supported now, we need to add test cases to cover: TopN, Projection, Selection.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Feb 14, 2023
@ti-chi-bot
Copy link
Member

Hi @Dousir9. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Dousir9
Copy link
Contributor Author

Dousir9 commented Feb 14, 2023

@guo-shaoge The check-issue-triage-complete fails, could you help me to resolve it? thanks.

@Dousir9 Dousir9 changed the title planner: add more check when pushing TopN down planner: add more checks when pushing TopN down Feb 14, 2023
@Dousir9
Copy link
Contributor Author

Dousir9 commented Feb 14, 2023

/cc fixdb

@Dousir9
Copy link
Contributor Author

Dousir9 commented Feb 14, 2023

/cc guo-shaoge

@qw4990 qw4990 added the sig/planner SIG: Planner label Feb 14, 2023
@qw4990 qw4990 self-requested a review February 14, 2023 06:33
qw4990
qw4990 reviewed Feb 14, 2023
View reviewed changes
planner/core/task.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Feb 14, 2023
View reviewed changes
planner/core/task.go Outdated Show resolved Hide resolved
guo-shaoge
guo-shaoge reviewed Feb 15, 2023
View reviewed changes
planner/core/task.go Outdated Show resolved Hide resolved
@guo-shaoge
Copy link
Collaborator

@guo-shaoge The check-issue-triage-complete fails, could you help me to resolve it? thanks.

Done

guo-shaoge
guo-shaoge reviewed Feb 15, 2023
View reviewed changes
planner/core/task.go Outdated Show resolved Hide resolved
@Dousir9
Copy link
Contributor Author

Dousir9 commented Feb 15, 2023

/retest

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023
@ti-chi-bot ti-chi-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. status/can-merge Indicates a PR has been approved by a committer. labels Feb 15, 2023
@chrysan
Copy link
Contributor

chrysan commented Feb 15, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 22a3980

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@Dousir9
Copy link
Contributor Author

Dousir9 commented Feb 15, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit d2d91b5 into pingcap:master Feb 15, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41464.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #41465.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@Dousir9 @ti-chi-bot
This is an automated cherry-pick of pingcap#41370
185f9ae 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41466.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@Dousir9 @ti-chi-bot
This is an automated cherry-pick of pingcap#41370
711770a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41467.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@Dousir9 @ti-chi-bot
This is an automated cherry-pick of pingcap#41370
767c640 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@Dousir9 @ghazalfamilyusa
planner: add more checks when pushing TopN down (pingcap#41370)
68a61de 
close pingcap#41355
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41470.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 16, 2023
@Dousir9 @ti-chi-bot
This is an automated cherry-pick of pingcap#41370
19f9ed7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 16, 2023
@ti-chi-bot
planner: add more checks when pushing TopN down (#41370) (#41470)
d52c620 
close #41355
ti-chi-bot added a commit that referenced this pull request Feb 17, 2023
@ti-chi-bot
planner: add more checks when pushing TopN down (#41370) (#41464)
daee8c5 
close #41355
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@ti-chi-bot @iosmanthus
planner: add more checks when pushing TopN down (pingcap#41370) (ping…
b4aafa8 
…cap#41470)

close pingcap#41355
ti-chi-bot added a commit that referenced this pull request Mar 29, 2023
@ti-chi-bot
planner: add more checks when pushing TopN down (#41370) (#41467)
38b33e5 
close #41355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge left review comments

@chrysan chrysan chrysan approved these changes

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@fixdb fixdb Awaiting requested review from fixdb

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 ok-to-test release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong result of topn for generated column
8 participants
@Dousir9 @ti-chi-bot @guo-shaoge @chrysan @AilinKid @qw4990 @purelind @jebter