stmtv2: ignore corrupted line when scan #41374
Conversation
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
size/L
| close(rowsCh) // task done | ||
| mgrWg.Wait() | ||
| close(rowsCh) // task done |
There was a problem hiding this comment.
Is the corrupted line caused by this?
There was a problem hiding this comment.
No. But if err occurs, closing rowsCh before workers are done can cause sending to a closed channel and then panic.
|
/run-check-issue-triage-complete |
ti-chi-bot
added
status/LGT2
| @@ -740,7 +748,7 @@ func (w *stmtParseWorker) run( | |||
| func (w *stmtParseWorker) handleLines( | |||
| lines [][]byte, | |||
| rowsCh chan<- [][]types.Datum, | |||
| errCh chan<- error, | |||
| _ chan<- error, | |||
There was a problem hiding this comment.
In case it becomes needed in future
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c9584f5
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: zhongzc zhongzc_arch@outlook.com
What problem does this PR solve?
Issue Number: close #41373
Problem Summary:
What is changed and how it works?
Ignore lines that fail to unmarshal
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.