Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support PROXY protocol fallback-able options #41393

Merged
merged 9 commits into from Feb 16, 2023

Conversation

blacktear23
Copy link
Contributor

@blacktear23 blacktear23 commented Feb 14, 2023

What problem does this PR solve?

Issue Number: close #41409

Problem Summary:

Add -proxy-protocol-fallbackable option to let TiDB can handle raw connection connect to TiDB and the IP address is in allowed IP list.

What is changed and how it works?

update go-proxyprotocol package to enable fallbackable support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add `-proxy-protocol-fallbackable` options to let TiDB can handle raw connection which client IP is in PROXY protocol allowed IP list.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Feb 14, 2023
@ti-chi-bot
Copy link
Member

Hi @blacktear23. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

go.mod Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@xhebox xhebox self-requested a review February 15, 2023 10:08
tidb-server/main.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
server/conn.go Show resolved Hide resolved
@xhebox
Copy link
Contributor

xhebox commented Feb 16, 2023

/run-check-issue-triage-complete

@xhebox
Copy link
Contributor

xhebox commented Feb 16, 2023

/test all

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2023
@xhebox
Copy link
Contributor

xhebox commented Feb 16, 2023

/test all

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2023
@xhebox
Copy link
Contributor

xhebox commented Feb 16, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3af1bb6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit 0519e7e into pingcap:master Feb 16, 2023
@xhebox
Copy link
Contributor

xhebox commented Feb 20, 2023

/cherry-pick release-6.5
/cherry-pick release-6.6

@ti-chi-bot
Copy link
Member

@xhebox: new pull request created to branch release-6.5: #41570.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@xhebox: new pull request created to branch release-6.6: #41571.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: TiDB cannot read the client's remote address in PROXY protocol header
5 participants