Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, com_stmt: store and restore the params for cursor fetch #41441

Merged
merged 1 commit into from Mar 15, 2023

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Feb 15, 2023

What problem does this PR solve?

Issue Number: close #40094

Problem Summary:

TiDB cannot handle concurrently running statements. This PR stores and restores the params.

What is changed and how it works?

Store and restore the prepared params in session

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

The following JDBC codes run without panic:

import java.sql.*;

public class Example {
    public static void main(String[] args) throws SQLException, InterruptedException {
        Connection conn = DriverManager.getConnection("jdbc:mysql://127.0.0.1:4000/test?useCursorFetch=true&useServerPrepStmts=true&useSSL=false", "root", "");

        conn.setAutoCommit(false); // must set

        conn.prepareStatement("drop table if exists t").execute();
        conn.prepareStatement("create table t (id int auto_increment primary key, id_2 int)").execute();
        conn.prepareStatement("insert into t values (1,1)").execute();
        conn.prepareStatement("insert into t values (2,2)").execute();

        // submit a statement with more arguments:
        PreparedStatement statement1 = conn.prepareStatement("" +
                "select * " +
                "from " +
                "t " +
                "where id = ? and id_2 = ?");
        statement1.setFetchSize(500);
        statement1.setInt(1, 1);
        statement1.setInt(2, 2);
        ResultSet rs_1 = statement1.executeQuery();

        // submit a statement with less arguments:
        PreparedStatement statement2 = conn.prepareStatement("" +
                "select * " +
                "from " +
                "t " +
                "where (id = ?)");
        statement2.setFetchSize(500);
        statement2.setInt(1, 1);
        ResultSet rs_2 = statement2.executeQuery();

        // fetch the result from the first argument
        while (rs_1.next()) {
            int result = rs_1.getInt(1);

            System.out.println(result);
        }
        while (rs_2.next()) {
            int result = rs_2.getInt(1);

            System.out.println(result);
        }

        statement1.close();
        statement2.close();
        conn.commit();
        conn.close();

    }
}

Release note

Fix the issue that the prepared params are lost while executing another statement between EXECUTE and FETCH command.

@YangKeao YangKeao requested a review from a team as a code owner February 15, 2023 08:12
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@YangKeao YangKeao changed the title session, com_stmt: store and restore the stmtctx for executed statements session, com_stmt: store and restore the stmtctx and variables for executed statements Feb 15, 2023
@YangKeao YangKeao changed the title session, com_stmt: store and restore the stmtctx and variables for executed statements session, com_stmt: store and restore the stmtctx for executing statements Feb 15, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 labels Feb 15, 2023
server/driver_tidb.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.6 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2023
@YangKeao YangKeao force-pushed the fix-40322 branch 2 times, most recently from d1a6927 to a0830a7 Compare March 8, 2023 09:04
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the specific case better, though not a complete fix for the whole related problem.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2023
@YangKeao
Copy link
Member Author

YangKeao commented Mar 9, 2023

/retest

@YangKeao YangKeao changed the title session, com_stmt: store and restore the stmtctx for executing statements session, com_stmt: store and restore the params for executing statements Mar 10, 2023
@YangKeao YangKeao changed the title session, com_stmt: store and restore the params for executing statements session, com_stmt: store and restore the params for cursor fetch Mar 10, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1963ef3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@ti-chi-bot ti-chi-bot merged commit 5f8002f into pingcap:master Mar 15, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #42238.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42239.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42240.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42241.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #42242.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 15, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
YangKeao added a commit to YangKeao/tidb that referenced this pull request Mar 22, 2023
YangKeao added a commit to YangKeao/tidb that referenced this pull request Mar 23, 2023
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create multiple cursor will cause panic
4 participants