Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: support auto_random column in composite primary key #41463

Merged
merged 4 commits into from Feb 16, 2023
Merged

lightning: support auto_random column in composite primary key #41463

merged 4 commits into from Feb 16, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Feb 15, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41454

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support generate value for auto_random column when it's in a composite primary key

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@D3Hunter
Copy link
Contributor Author

/run-unit-test

@D3Hunter D3Hunter marked this pull request as ready for review February 16, 2023 03:52
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
@D3Hunter D3Hunter added the component/lightning This issue is related to Lightning of TiDB. label Feb 16, 2023
@D3Hunter
Copy link
Contributor Author

/run-all-tests
/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2023
@D3Hunter @sleepymole
Update br/tests/lightning_auto_random_default/run.sh
4e2b3da 
Co-authored-by: Yujie Xia <xiayjchn@gmail.com>
@D3Hunter
Copy link
Contributor Author

/run-all-tests
/run-integration-br-test

lichunzhu
lichunzhu approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2023
@D3Hunter
Copy link
Contributor Author

lightning ci pass https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/15225/pipeline

@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4e2b3da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit 6837bd5 into master Feb 16, 2023
@ti-chi-bot ti-chi-bot deleted the fix-auto-random-compisite-key branch February 16, 2023 05:40
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41481.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 16, 2023
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#41463
7a3e4c0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41482.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 16, 2023
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#41463
da379fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41483.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41484.

ti-chi-bot added a commit that referenced this pull request Feb 16, 2023
@ti-chi-bot
lightning: support auto_random column in composite primary key (#41463)…
4958321 
… (#41484)

close #41454
ti-chi-bot added a commit that referenced this pull request Feb 16, 2023
@ti-chi-bot
lightning: support auto_random column in composite primary key (#41463)…
d608d93 
… (#41483)

close #41454
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@ti-chi-bot @iosmanthus
lightning: support auto_random column in composite primary key (pingc…
f6c49dd 
…ap#41463) (pingcap#41484)

close pingcap#41454
ti-chi-bot added a commit that referenced this pull request Mar 29, 2023
@ti-chi-bot
lightning: support auto_random column in composite primary key (#41463)…
020f936 
… (#41482)

close #41454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: cannot generate value for auto_random column if it's in a composite primary key
5 participants
@D3Hunter @ti-chi-bot @sleepymole @lichunzhu @niubell