Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: set switch default to false (#41336) #41542

Merged
merged 2 commits into from
Feb 21, 2023
Merged

telemetry: set switch default to false (#41336) #41542

merged 2 commits into from
Feb 21, 2023

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Feb 17, 2023 •
edited

Issue Number: #41335

This is a manual cherry-pick of #41336

Close: #41436 as it was a mess.

Disable telemetry report by default.

@AstroProfundis AstroProfundis requested a review from a team as a code owner February 17, 2023 08:59
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mornyx
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2023
@AstroProfundis
Copy link
Contributor Author

/cc @Reviewer

@ti-chi-bot
Copy link
Member

@AstroProfundis: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AstroProfundis
Copy link
Contributor Author

/cc @bb7133 @cfzjywxk @jackysp @qw4990 @XuHuaiyu

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 21, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. release-note and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2023
@qw4990
Copy link
Contributor

qw4990 commented Feb 21, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e59a3e4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2023
@ti-chi-bot ti-chi-bot merged commit 73d82e3 into pingcap:release-6.1 Feb 21, 2023
@AstroProfundis AstroProfundis deleted the cp-41336-6.1 branch February 21, 2023 13:23
@VelocityLight VelocityLight removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@mornyx mornyx mornyx approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@jackysp jackysp Awaiting requested review from jackysp

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AstroProfundis @ti-chi-bot @qw4990 @mornyx @VelocityLight