Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix error handling of DateAddString vectorized function #41786

Merged
merged 3 commits into from Mar 2, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Feb 28, 2023

What problem does this PR solve?

Issue Number: close #40015

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/needs-triage-completed release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2023
@SeaRise SeaRise changed the title fix Fix error handling of DateAddString vectorized function Feb 28, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2023

/retest

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2023

/cc @XuHuaiyu @guo-shaoge @wshwsh12

@SeaRise SeaRise changed the title Fix error handling of DateAddString vectorized function expression: Fix error handling of DateAddString vectorized function Feb 28, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2023

/retest

@SeaRise SeaRise changed the title expression: Fix error handling of DateAddString vectorized function expression: fix error handling of DateAddString vectorized function Feb 28, 2023
@SeaRise SeaRise changed the title expression: fix error handling of DateAddString vectorized function expression: fix error handling of DateAddString vectorized function Feb 28, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
@ti-chi-bot ti-chi-bot merged commit cfe9703 into pingcap:master Mar 2, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #41850.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #41851.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #41852.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #41853.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #41854.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41855.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #41856.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #41857.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41858.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@SeaRise SeaRise deleted the fix_error_handle_in_add_day branch March 2, 2023 06:58
@SeaRise
Copy link
Contributor Author

SeaRise commented May 8, 2023

/review default

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2023

@SeaRise:

Review for PR #40015

Summary

This PR fixes an issue with error handling in DateAddString vectorized function.

Changes Made

The issue is fixed by handling ErrWrongValue error in the case where SQLMode has NoZeroDateMode. The method now returns the error and sets the result to null accordingly.

Potential Problems

There seem to be no potential issues with this change.

Suggestions

None.

Overall Review

This is a small change with well-defined benefits and it seems to be implemented correctly. Therefore, my overall review is positive.

Tests

There is a new unit test added to ensure the proper functioning of this change. In addition, there is also a new integration test added.

Release Note

This change doesn't require a release note.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical bug: value changed after relaxing ON condition [v5.0.2, v6.4.0]
4 participants