Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: fix the issue that gc-worker owner cannot check log-backup task existed. #41824

Merged
merged 6 commits into from Mar 2, 2023

Conversation

joccau
Copy link
Member

@joccau joccau commented Mar 1, 2023

What problem does this PR solve?

Issue Number: close #41806
close #41642

Problem Summary:
If the gc-worker owner and the pitr owner is not the same node, the gc-worker owner cannot check the log-backup task existed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test

  • Create a TiDB cluster with the 3 tidb-server, 3 pd-server and 3 tikv-server.
  • Create a log-backup task, Search the log in all of tidb-server, the log like this
2023-03-01 16:38:04 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 16:38:07 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 16:38:10 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
  • restart all of tidb-server, and search the log
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]
  • stop a log-backup task. Search the log
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:212] ["dec log backup task"] [count=0]
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:212] ["dec log backup task"] [count=0]
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:212] ["dec log backup task"] [count=0]
  • start the log-backup task again, and search the log
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the issue that gc owner cannot check log-backup task existed

Signed-off-by: joccau <zak.zhao@pingcap.com>
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Copy link
Member Author

joccau commented Mar 1, 2023

/run-integration-br-test

Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Copy link
Member Author

joccau commented Mar 1, 2023

/run-integration-br-test

@joccau joccau changed the title log-backup: fix the issue that gc owner cannot check log-backup task existed. log-backup: fix the issue that gc-worker owner cannot check log-backup task existed. Mar 1, 2023
@ti-chi-bot
Copy link
Member

@tonyxuqqi: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2023
Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2023
@joccau
Copy link
Member Author

joccau commented Mar 2, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 399df3c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2023
@YuJuncen
Copy link
Contributor

YuJuncen commented Mar 2, 2023

/merge

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #41847.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 2, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41848.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #41849.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
5 participants