Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add keyspace into log #41844

Merged
merged 3 commits into from Mar 6, 2023
Merged

util: add keyspace into log #41844

merged 3 commits into from Mar 6, 2023

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented Mar 2, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41843

Problem Summary:

What is changed and how it works?

add keyspace into log

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. start tidb with keyspace
  2. execute some sql
  3. view tidb logs

start tidb with keyspace
image

start tidb without keyspace
image

Side effects

  • Performance regression: Consumes more CPU

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add keyspace into log

@zeminzhou
log with keyspace
288128b 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@zeminzhou zeminzhou requested a review from a team as a code owner March 2, 2023 03:56
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2023
CbcWestwolf
CbcWestwolf approved these changes Mar 2, 2023
View reviewed changes
sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2023
@zeminzhou
reuse wrapcore with keyspace
141cc34 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@CbcWestwolf CbcWestwolf changed the title [util]: add keyspace into log util: add keyspace into log Mar 2, 2023
@CbcWestwolf
Copy link
Member

/cc bb7133

@ti-chi-bot ti-chi-bot requested a review from bb7133 March 2, 2023 05:23
@zeminzhou
make check
33a7031 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ystaticy
Copy link
Contributor

ystaticy commented Mar 6, 2023

Can you add result of manual test in this PR description?

@zeminzhou
Copy link
Contributor Author

Can you add result of manual test in this PR description?

Sure, I added manual test, PTAL~

bb7133
bb7133 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2023
ystaticy
ystaticy approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@ystaticy ystaticy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@ystaticy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zeminzhou
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@zeminzhou: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CbcWestwolf
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 33a7031

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023
@zeminzhou
Copy link
Contributor Author

/test unit-test

@zeminzhou
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot merged commit a39d7fb into pingcap:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@ystaticy ystaticy ystaticy approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees
No one assigned
Labels
release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach keyspace to logs
5 participants
@zeminzhou @ti-chi-bot @CbcWestwolf @ystaticy @bb7133