Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stmtsummary: stmtsummary with keyspace #41882

Merged
merged 4 commits into from Mar 6, 2023

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented Mar 2, 2023

What problem does this PR solve?

Issue Number: close #41881

Problem Summary:

What is changed and how it works?

StmtsummaryV2 with keyspace

Check List

Tests

  • Unit test
  • Integration test
  • Maual test
  1. start tidb with config
keyspace-name = "keyspace_a"
[instance]
tidb_stmt_summary_enable_persistent = true
tidb_stmt_summary_file_max_size = 25
tidb_stmt_summary_file_max_backups = 3
  1. execute set @@global.tidb_stmt_summary_refresh_interval=30;
  2. view log file, keyspace found in log file
    image

//==============

  1. start tidb with config
[instance]
tidb_stmt_summary_enable_persistent = true
tidb_stmt_summary_file_max_size = 25
tidb_stmt_summary_file_max_backups = 3
  1. execute set @@global.tidb_stmt_summary_refresh_interval=30;
  2. view log file, keyspace didn't found in log file
    image

Side effects

No

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

stmtsummary with keyspace

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mornyx
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2023
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2023
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2023
@ystaticy
Copy link
Contributor

ystaticy commented Mar 6, 2023

LGTM

@disksing
Copy link
Contributor

disksing commented Mar 6, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c73d76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023
@ti-chi-bot ti-chi-bot merged commit f43b1bb into pingcap:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach keyspace to stmtsummary
7 participants