executor: unify replace into logic for InsertValues and ReplaceExec #41947
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
size/XL
|
@lance6716 a test case fails. |
Signed-off-by: lance6716 <lance6716@gmail.com>
executor/insert_common.go
Outdated
| @@ -338,7 +338,8 @@ func (e *InsertValues) handleErr(col *table.Column, val *types.Datum, rowIdx int | |||
| } | |||
| err = completeInsertErr(c, val, rowIdx, err) | |||
|
|
|||
| if !e.ctx.GetSessionVars().StmtCtx.DupKeyAsWarning { | |||
| // TODO: why we rely on DupKeyAsWarning here? | |||
| if !e.ctx.GetSessionVars().StmtCtx.DupKeyAsWarning && !e.ctx.GetSessionVars().StmtCtx.InLoadDataStmt { | |||
There was a problem hiding this comment.
It looks good to me, here. If you want to support non-local load data statement, you could modify here.
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
|
CI is passed, ptal |
|
PTAL @jackysp @crazycs520 @hawkingrei , a small PR |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 051e98b
|
ti-chi-bot
added
status/can-merge
Signed-off-by: lance6716 <lance6716@gmail.com>
ti-chi-bot
removed
the
status/can-merge
ti-chi-bot
removed
the
needs-rebase
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5bd4f95
|
ti-chi-bot
added
the
status/can-merge
|
/retest |
|
/cherry-pick release-6.5 |
|
@lance6716: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #40499
Problem Summary:
What is changed and how it works?
in the old code, LOAD DATA only support LOCAL modifier which is equal to IGNORE, and the LOAD DATA REPLACE INTO behaviour is not fully implemented. Now LOAD DATA REPLACE INTO should be OK.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.