Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: register import task to pd #41956

Merged
merged 7 commits into from Mar 14, 2023
Merged

br: register import task to pd #41956

merged 7 commits into from Mar 14, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Mar 6, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41536

Problem Summary:
log backup task is conflict with restore/lightning

What is changed and how it works?

register task key with ttl to pd, and keepalive it during running.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Register restore task to pd so that it can be found by the backup task.

@Leavrth
draft
032f9d8 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix bug
0650ce0 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 6, 2023
@Leavrth
bazel lint
3bfb3fd 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@charleszheng44 charleszheng44 mentioned this pull request Mar 8, 2023
Closed
@Leavrth
use duration type for ttl
62c7d37 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
YuJuncen
YuJuncen approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/utils/register.go Outdated
timeLeftThreshold = tr.ttl
})
var lastUpdateTime time.Time = time.Now()
var err error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge these variable definitions into one block like:

var (
  foo = somewhat
  bar = somewhat
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

br/pkg/utils/register.go
func (list RegisterTasksList) MessageToUser() string {
var tasksMsgBuf strings.Builder
for _, task := range list.Tasks {
tasksMsgBuf.WriteString(task.MessageToUser())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some whitespaces between tasks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
joccau
joccau approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Nice code! good job!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2023
@joccau
Copy link
Member

joccau commented Mar 13, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 62c7d37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@Leavrth
commit some suggestions
de7b317 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@Leavrth
commit some suggestions
ea3addc 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Mar 13, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Mar 13, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f1b4c44

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Mar 14, 2023

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@joccau
Copy link
Member

joccau commented Mar 14, 2023

/run-integration-br-test

@ti-chi-bot ti-chi-bot merged commit 9947add into pingcap:master Mar 14, 2023
6 checks passed
@Leavrth Leavrth mentioned this pull request Apr 6, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@joccau joccau joccau approved these changes

Assignees
No one assigned
Labels
release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log backup task is conflict with restore/lightning
5 participants
@Leavrth @ti-chi-bot @joccau @hawkingrei @YuJuncen