Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support mergeSort different selectResult in TableScan and IndexScan #42024

Merged
merged 15 commits into from Mar 14, 2023
Merged

executor: support mergeSort different selectResult in TableScan and IndexScan #42024

merged 15 commits into from Mar 14, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Mar 8, 2023 •
edited

What problem does this PR solve?

Issue Number: close #41801, ref #26166

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none needs-cherry-pick-release-6.5 do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 8, 2023
@Defined2014 Defined2014 force-pushed the mergeSort branch 4 times, most recently from a93e1e7 to 388b3ed Compare March 9, 2023 02:04
@Defined2014 Defined2014 force-pushed the mergeSort branch 2 times, most recently from 0079bfe to 1568ba7 Compare March 9, 2023 06:38
@Defined2014 Defined2014 changed the title [WIP] partition: support mergeSort different selectResult in TableScan and IndexScan [WIP] executor: support mergeSort different selectResult in TableScan and IndexScan Mar 9, 2023
winoros
winoros reviewed Mar 9, 2023
View reviewed changes
distsql/select_result.go Outdated Show resolved Hide resolved
executor/partition_table.go Show resolved Hide resolved
@winoros winoros mentioned this pull request Mar 13, 2023
Closed
12 tasks
@Defined2014
Copy link
Contributor Author

/test build

winoros
winoros reviewed Mar 14, 2023
View reviewed changes
executor/distsql.go Outdated Show resolved Hide resolved
@Defined2014 Defined2014 changed the title [WIP] executor: support mergeSort different selectResult in TableScan and IndexScan executor: support mergeSort different selectResult in TableScan and IndexScan Mar 14, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
winoros
winoros approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very clean implementation for me!
Except that golang doesn't provide a generic heap implementation in std lib yet.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
Defined2014
Defined2014 commented Mar 14, 2023
View reviewed changes
executor/distsql.go Outdated Show resolved Hide resolved
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 873200c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@Defined2014
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot merged commit cc56b21 into pingcap:master Mar 14, 2023
@Defined2014 Defined2014 deleted the mergeSort branch March 14, 2023 14:35
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 14, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42224.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 14, 2023
@Defined2014 @ti-chi-bot
This is an automated cherry-pick of pingcap#42024
c930c4f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Defined2014 Defined2014 mentioned this pull request Mar 15, 2023
Open
@tiancaiamao tiancaiamao mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the subquery result is wrong
4 participants
@Defined2014 @ti-chi-bot @winoros @XuHuaiyu