Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade go 1.20.2 #42046

Merged
merged 3 commits into from Mar 9, 2023
Merged

*: upgrade go 1.20.2 #42046

merged 3 commits into from Mar 9, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 9, 2023 •
edited

What problem does this PR solve?

Issue Number: close #42047

Problem Summary:

What is changed and how it works?

golang/go#57523

It is solved. It is very importance to improve our performance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 9, 2023
zyguan
zyguan approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2023
@hawkingrei hawkingrei requested a review from bb7133 March 9, 2023 03:34
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2023
@hawkingrei
*: upgrade go 1.20.2
eadc0a8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go 1.20.2
76f976d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go 1.20.2
1317a17 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/test unit-test

bb7133
bb7133 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Mar 9, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1317a17

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2023
@ti-chi-bot ti-chi-bot merged commit b182db2 into pingcap:master Mar 9, 2023
@hawkingrei hawkingrei deleted the upgrade_1202 branch March 9, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@zyguan zyguan zyguan approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade go 1.20.2
5 participants
@hawkingrei @ti-chi-bot @bb7133 @zyguan @Defined2014