Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn, session: Rename Aggressive Locking to Fair Locking and enable by default for new clusters #42108

Merged
merged 3 commits into from Mar 14, 2023
Merged

txn, session: Rename Aggressive Locking to Fair Locking and enable by default for new clusters #42108

merged 3 commits into from Mar 14, 2023

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Mar 10, 2023 •
edited

What problem does this PR solve?

Issue Number: ref #42107 , close #42147

Problem Summary:

This PR does the following changes:

  1. Rename the term Aggressive Locking to Fair Locking for all places, including the system variable, telemetry item and metrics.
  2. Enable tidb_pessimistic_txn_fair_locking by default for new clusters, but clusters upgraded from older version will still have this option disabled.
  3. Adapt some tests that doesn't work well with tidb_pessimistic_txn_fair_locking globally enabled.

The term Aggressive Locking is also used in client-go which is not updated for now, thus the old term still occurs in code that references to client-go. We will also rename it in client-go later.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Rename variable `tidb_pessimistic_txn_aggressive_locking` into `tidb_pessimistic_txn_fair_locking` and enable by default for new clusters.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 10, 2023
@MyonKeminta
Copy link
Contributor Author

/test all

@MyonKeminta
Fix variable info test
c7aa063 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

/test all

@MyonKeminta
Copy link
Contributor Author

/test unit-test

@MyonKeminta MyonKeminta marked this pull request as ready for review March 13, 2023 05:52
@MyonKeminta MyonKeminta requested a review from a team as a code owner March 13, 2023 05:52
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7aa063

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@MyonKeminta MyonKeminta mentioned this pull request Mar 13, 2023
Merged
16 tasks
@MyonKeminta
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@MyonKeminta
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@MyonKeminta
Copy link
Contributor Author

/merge

@MyonKeminta
Copy link
Contributor Author

/build

@MyonKeminta
Copy link
Contributor Author

/rebuild

@MyonKeminta
Copy link
Contributor Author

/test build

1 similar comment
@MyonKeminta
Copy link
Contributor Author

/test build

@cfzjywxk
Copy link
Contributor

/test unit-test

@ti-chi-bot ti-chi-bot merged commit cc54d1b into pingcap:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium ekexium approved these changes

Assignees
No one assigned
Labels
release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable fair locking model of pessimistic transactions by default
4 participants
@MyonKeminta @ti-chi-bot @cfzjywxk @ekexium