Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refactor add index worker for ingest mode #42115

Merged
merged 10 commits into from Mar 14, 2023
Merged

ddl: refactor add index worker for ingest mode #42115

merged 10 commits into from Mar 14, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 10, 2023 •
edited

What problem does this PR solve?

Problem Summary:

Code refactor, skip issue check.

What is changed and how it works?

Separate the ingest mode from the transaction mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2023
zimulala
zimulala reviewed Mar 13, 2023
View reviewed changes
ddl/backfilling.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
@tangenta
Copy link
Contributor Author

/retest

zimulala
zimulala approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2023
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a904123

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

2 similar comments
@wjhuang2016
Copy link
Member

/retest

@wjhuang2016
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit 4e2e11b into pingcap:master Mar 14, 2023
@zimulala zimulala mentioned this pull request Mar 21, 2023
Closed
tangenta added a commit to tangenta/tidb that referenced this pull request Mar 21, 2023
@tangenta
Revert "ddl: refactor add index worker for ingest mode (pingcap#42115)"
4538479 
This reverts commit 4e2e11b.
ti-chi-bot pushed a commit that referenced this pull request Mar 22, 2023
@tangenta
Revert "ddl: refactor add index worker for ingest mode (#42115)" (#42438
42957c5 
)

close #42436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tangenta @ti-chi-bot @zimulala @hawkingrei @wjhuang2016