ddl: fix dist-reorg bugs #42204
ddl: fix dist-reorg bugs #42204
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
needs-cherry-pick-release-6.6
size/M
| @@ -326,7 +326,7 @@ func addBatchBackfillJobs(sess *session, reorgInfo *reorgInfo, sJobCtx *splitJob | |||
| func (dc *ddlCtx) splitTableToBackfillJobs(sess *session, reorgInfo *reorgInfo, sJobCtx *splitJobContext, pTblMeta *BackfillJobRangeMeta) error { | |||
There was a problem hiding this comment.
This function update for fixing #42176
| @@ -544,6 +544,10 @@ func (dc *ddlCtx) newReorgCtx(jobID int64, startKey []byte, currElement *meta.El | |||
| return rc | |||
| } | |||
|
|
|||
| func genBackfillJobReorgCtxID(jobID int64) int64 { | |||
| return -jobID | |||
There was a problem hiding this comment.
too hacker here :(
Correct use ref is the better way.
There was a problem hiding this comment.
Maybe we could remove it later.
There was a problem hiding this comment.
Yes, it should be removed in next sprint.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 4956018
|
ti-chi-bot
added
the
status/can-merge
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #42176, close #42199, close #42175
Problem Summary:
What is changed and how it works?
checkBackfillJobCount#42175: addddl_physical_tidinfo for SQL.remainto dist-reorg logical.ReorgCtx, otherwise may affect the tmp merge state #42199: backfill job use a newreorgCtx.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.