Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: init default resource group without ddl #42478

Merged
merged 3 commits into from Mar 23, 2023
Merged

resource_control: init default resource group without ddl #42478

merged 3 commits into from Mar 23, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Mar 22, 2023

What problem does this PR solve?

Issue Number: close #42403

Problem Summary:

What is changed and how it works?

In the old implementation, we init the default resource group via a ddl job after tidb is bootstraped. This has a compatible issue because there are some instances that is not upgraded, thus these instances can not recognise this ddl and upgrade can be stuck.

This change resolve this issue by init the default resource group when first init the resource group manager, after this change the default resource group is not persistented to the storage by default, but this is ok as tidb will create one in memory when the default is not exist. The pd side change is: tikv/pd#6206. With these two changes, we can ensure the default resource group is always inited and there is no compatible issues.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • After this change, I manually upgrade a cluster(with 3 tidb instances), all tidb can bootstrap successfully and the default group's behavior is the same as before(at the user's view).
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@glorv glorv requested a review from a team as a code owner March 22, 2023 09:49
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BornChanger
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2023
@glorv
Copy link
Contributor Author

glorv commented Mar 22, 2023

@nolouch @BornChanger @wjhuang2016 PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2023
@glorv
Copy link
Contributor Author

glorv commented Mar 22, 2023

/retest

3 similar comments
@glorv
Copy link
Contributor Author

glorv commented Mar 22, 2023

/retest

@glorv
Copy link
Contributor Author

glorv commented Mar 22, 2023

/retest

@glorv
Copy link
Contributor Author

glorv commented Mar 22, 2023

/retest

bb7133
bb7133 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 61972b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@glorv
Copy link
Contributor Author

glorv commented Mar 23, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 5c7db35 into pingcap:master Mar 23, 2023
8 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42505.

@glorv glorv deleted the fix-default-rg branch March 23, 2023 06:19
ti-chi-bot added a commit that referenced this pull request Mar 23, 2023
@ti-chi-bot
resource_control: init default resource group without ddl (#42478) (#…
624aa88 
…42505)

close #42403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@nolouch nolouch nolouch approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.0 release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade from 6.3 to master hit tidb panic due to doReentrantDDL error
6 participants
@glorv @ti-chi-bot @bb7133 @nolouch @wjhuang2016 @BornChanger