Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, ddl: correct the job type of 'REORGANIZE PARTITION' #42490

Merged
merged 1 commit into from Mar 22, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Mar 22, 2023

What problem does this PR solve?

Issue Number: close #42442

Problem Summary:

What is changed and how it works?

See the comments in #42442:

The root cause is that we didn't mark "reorganize partition" as "need backfill" so it is scheduled as the 'general job', and the 'general job' is scheduled in serial(always block each others).

This PR simply fixes this.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Like #42442, concurrently run CREATE TABLE and REORGANIZE PARTITION in 2 sessions:

session1(first)> alter table t1 reorganize partition p0, p1, p2, p3, p4 into( partition pnew values less than (10000000));
session2(second)> create table t01(a int, b int);

We can verify that create table will not be blocked anymore.

  • No code

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: bb7133 <bb7133@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@bb7133
Copy link
Member Author

bb7133 commented Mar 22, 2023

"Release note" is NONE because bug #42442 is not released yet.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2023
@xhebox
Copy link
Contributor

xhebox commented Mar 22, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a403bba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit ecd596a into pingcap:master Mar 22, 2023
3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42494.

@bb7133 bb7133 deleted the bb7133/fix_42442 branch March 23, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.0 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reorganize partition can not concurrent run ddl with other ddl
5 participants