Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resourcemanager: support worker pool #42513

Merged
merged 10 commits into from Mar 25, 2023
Merged

resourcemanager: support worker pool #42513

merged 10 commits into from Mar 25, 2023

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 23, 2023 •
edited

What problem does this PR solve?

Issue Number: close #42511

Problem Summary:

What is changed and how it works?

This PR supports a worker pool that can change workers dynamically by the resource manager.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016
done
96f2846 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2023
@wjhuang2016
refine
a44031d 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
address comment
4976c90 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2023
@wjhuang2016
use T
64c430b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2023
@wjhuang2016
refine
0971b54 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
refine
5e3ee68 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
refine
3f78a08 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
hawkingrei
hawkingrei reviewed Mar 23, 2023
View reviewed changes
resourcemanager/pool/workerpool/workerpool.go Outdated
select {
case task := <-p.taskChan:
p.runningTask.Add(1)
w.HandleTask(task)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add recoveryhere to avoid panic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let the worker handle it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If wokrer forgets to handle it, how to ensure the correctness here.

@wjhuang2016
support recover
9200b6b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
587e584 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix build
8cb812f 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cb812f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit d3c0756 into pingcap:master Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support a worker pool
4 participants
@wjhuang2016 @ti-chi-bot @hawkingrei @tangenta