Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: improve unit test #42527

Merged
merged 19 commits into from Mar 24, 2023
Merged

*: improve unit test #42527

merged 19 commits into from Mar 24, 2023

Conversation

hawkingrei
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2023
@hawkingrei
infoschema: fix data race in the SessionExtendedInfoSchema
ab40094 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: fix data race in the SessionExtendedInfoSchema
a4c9321 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: fix data race in the SessionExtendedInfoSchema
a697467 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: fix data race in the SessionExtendedInfoSchema
c1f0d24 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
infoschema: fix data race in the SessionExtendedInfoSchema
e3d3022 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
7ecb4fb 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
390f814 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
87244bd 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
802d13d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6f8bfda 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
3df58d0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
2c87cc2 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested a review from a team as a code owner March 23, 2023 14:34
@hawkingrei
update
f01d422 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
add81e6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
09b9f50 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
09c1941 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@hawkingrei hawkingrei requested review from Defined2014 and xhebox and removed request for a team March 24, 2023 02:24
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 09c1941

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
update
4f1bb6f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f1bb6f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
7c7addf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c7addf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
update
a67695d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member Author

/mrege

1 similar comment
@hawkingrei
Copy link
Member Author

/mrege

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a67695d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@ti-chi-bot ti-chi-bot merged commit cb12d33 into pingcap:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@Defined2014 Defined2014 Awaiting requested review from Defined2014

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hawkingrei @ti-chi-bot @lance6716 @CbcWestwolf