Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: misuse IsTelemetryEnabled in the selectResult.fetchResp #42542

Merged
merged 2 commits into from Mar 25, 2023
Merged

distsql: misuse IsTelemetryEnabled in the selectResult.fetchResp #42542

merged 2 commits into from Mar 25, 2023

Conversation

hawkingrei
Copy link
Member

What problem does this PR solve?

Issue Number: close #42507

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-release-7.0 and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Mar 24, 2023
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0aaa9dd00d7b0eeaf9e92b270bbc4c84a08fab40

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@hawkingrei
Copy link
Member Author

/test all

@tangenta tangenta mentioned this pull request Mar 24, 2023
Open
@hawkingrei
Copy link
Member Author

/retest

9 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@wuhuizuo
Copy link
Contributor

/retest

@hawkingrei
Copy link
Member Author

/retest

@Benjamin2037
Copy link
Collaborator

/merge

@Benjamin2037
Copy link
Collaborator

/retest

@hawkingrei
Copy link
Member Author

/test all

@hawkingrei
distsql: misuse IsTelemetryEnabled in the selectResult.fetchResp
24b0edc 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
b2eea19 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2023
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@Benjamin2037
Copy link
Collaborator

/retest

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b2eea19

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2023
@hawkingrei
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot merged commit b00c646 into pingcap:master Mar 25, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.0 from head ti-chi-bot:cherry-pick-42542-to-release-7.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.0 and ti-chi-bot:cherry-pick-42542-to-release-7.0"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.0 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scratch installed v7.0.0 tidb started fail
6 participants
@hawkingrei @ti-chi-bot @wjhuang2016 @wuhuizuo @Benjamin2037 @wshwsh12