Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: reimplement the backfill scheduler #42668

Merged
merged 8 commits into from Mar 29, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 29, 2023

What problem does this PR solve?

Problem Summary:

This is a refactoring PR, let's skip the issue check.

What is changed and how it works?

This PR extracts backfillScheduler to an interface:

// backfillScheduler is used to manage the lifetime of backfill workers.
type backfillScheduler interface {
	setupWorkers() error
	close(force bool)

	sendTask(task *reorgBackfillTask) error
	drainTasks()
	receiveResult() (*backfillResult, bool)

	setMaxWorkerSize(maxSize int)
	currentWorkerSize() int
	adjustWorkerSize() error
}

There are two implementations:

  • txnBackfillScheduler: the transaction way to backfill data.
  • ingestBackfillScheduler: the ingest way to backfill data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2023
@tangenta tangenta added skip-issue-check and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 29, 2023
ddl/backfilling_scheduler.go Outdated Show resolved Hide resolved
ddl/backfilling_scheduler.go Outdated Show resolved Hide resolved
ddl/backfilling_scheduler.go Outdated Show resolved Hide resolved
ddl/backfilling_scheduler.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2023
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2023
@Benjamin2037
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c48e80b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2023
@ti-chi-bot ti-chi-bot merged commit ed596f9 into pingcap:master Mar 29, 2023
8 checks passed
@@ -89,7 +89,9 @@ func (bc *BackendContext) Flush(indexID int64) error {
return err
}

if bc.diskRoot.CurrentUsage() >= uint64(importThreshold*float64(bc.diskRoot.MaxQuota())) {
release := ei.AcquireFlushLock()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does here need an engine flush lock?

b.taskCh <- task
}

func (b *txnBackfillScheduler) drainTasks() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if using a select instead only for loop better?
func (b *ingestBackfillScheduler) drainTasks() {
for {
select {
case <-b.taskCh:
// Discard message from channel
default:
// Channel is empty, exit loop
return
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants