Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: refine index/column stats methods #42910

Merged
merged 3 commits into from Apr 11, 2023
Merged

statistics: refine index/column stats methods #42910

merged 3 commits into from Apr 11, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #42160

Problem Summary:

What is changed and how it works?

  1. Introduce IsAnalyzed and StatsCollected to improve encapsulation.
  2. Make TableAnalyzed more precise.
  3. Make (StatsLoadedStatus).IsLoadNeeded more precise.
  4. Make (*Table).GetColRowCount neat.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2023
xuyifangreeneyes
xuyifangreeneyes commented Apr 11, 2023
View reviewed changes
statistics/handle/update.go
@@ -998,12 +998,12 @@ var AutoAnalyzeMinCnt int64 = 1000
// TableAnalyzed checks if the table is analyzed.
func TableAnalyzed(tbl *statistics.Table) bool {
for _, col := range tbl.Columns {
if col.Count > 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition is not precise, since a newly-added column has generated stats according to its default value but it may be not analyzed.

xuyifangreeneyes
xuyifangreeneyes commented Apr 11, 2023
View reviewed changes
statistics/handle/update.go
return true
}
}
for _, idx := range tbl.Indices {
if idx.Histogram.Len() > 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition is not precise, since idx.Histogram may be evicted.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2023
time-and-fate
time-and-fate reviewed Apr 11, 2023
View reviewed changes
statistics/column.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member

/retest

@xuyifangreeneyes
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8873b46

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2023
@hawkingrei
Copy link
Member

/retest

@xuyifangreeneyes
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot merged commit a133845 into pingcap:master Apr 11, 2023
8 checks passed
@xuyifangreeneyes xuyifangreeneyes deleted the stats-method branch April 12, 2023 00:21
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 7ba7dc7 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Jun 5, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xuyifangreeneyes @ti-chi-bot @hawkingrei @qw4990 @time-and-fate