ddl: Fix issue with truncate table and partitions and tiflash

[mjonss]

Allocate the table ids at once already in the DDL query session and send them to the ddl worker.

What problem does this PR solve?

Issue Number: close #42940

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Manual test:
Build the tidb binary
Start a playground cluster with

tiup playground nightly --db 1 --db.binpath bin/tidb-server --kv 3 --pd 1 --tiflash 2 --without-monitor

Run the prepare step:

create table t (a int) partition by hash (a) partitions 256;
insert into t values (1),(2),(3),(4),(5),(6),(7),(8);
insert into t select t1.a * t2.a * t3.a * t4.a from t t1, t t2, t t3, t t4;
insert into t select t1.a + t2.a from t t1, t t2 LIMIT 1000000;
alter table t set tiflash replica 2;

Wait to the TiFlash replicas are available:

tidb> select * from information_schema.tiflash_replica;
+--------------+------------+----------+---------------+-----------------+-----------+----------+
| TABLE_SCHEMA | TABLE_NAME | TABLE_ID | REPLICA_COUNT | LOCATION_LABELS | AVAILABLE | PROGRESS |
+--------------+------------+----------+---------------+-----------------+-----------+----------+
| test         | t          |       88 |             2 |                 |         1 |        1 |
+--------------+------------+----------+---------------+-----------------+-----------+----------+
1 row in set (0.00 sec)

Then just run truncate table t over and over again and check the tidb.log for 'handle ddl job failed'
Without the fix it comes within a few truncate tables
With the fix it did not show up after 10+ truncate tables

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug when truncate table with partitions and tiflash, where it would fail and had to retry the DDL job.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bb7133
• lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lcwangchao]

Rest LGTM

[bb7133]

LGTM

[mjonss]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 0e9e0f5

[Ivy-YinSu]

/test mysql-test

[lcwangchao]

/retest

[mjonss]

/retest

[lcwangchao]

/retest

[lcwangchao]

/retest

[lcwangchao]

/retest

[mjonss]

/retest

[hawkingrei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 10c50c9

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #43005.

[ti-chi-bot]

In response to a cherrypick label: failed to apply #42957 on top of branch "release-6.5":

failed to git commit: exit status 1

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.0: #43006.

[ti-chi-bot]

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/mysql-test	0e9e0f5	link	true	/test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.