Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staistics: fix load stats from old version json | tidb-test=pr/2114 #42967

Merged
merged 2 commits into from Apr 12, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42931

Problem Summary:

What is changed and how it works?

When v4.0.x and earlier versions dump stats json, stats json doesn't contain StatsVer. Before the PR, when we find stats json does not contain StatsVer, we just simply set its StatsVer to 1. Another fact is that we use StatsVer != 0 to decide whether stats are collected(i.e., analyze has been executed). Setting StatsVer to 1 for stats json from old versions makes us unable to distinguish whether stats are collected or not. Hence, after the PR, when we find stats json does not contain StatsVer, we check NDV > 0 || NullCount > 0 to decide whether stats are collected. If stats are collected, we set its StatsVer to 1, otherwise we set its StatsVer to 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2023
@xuyifangreeneyes xuyifangreeneyes changed the title staistics: fix load stats from old version json staistics: fix load stats from old version json | tidb-test=pr/2114 Apr 12, 2023
@xuyifangreeneyes
Copy link
Contributor Author

/test mysql-test

@xuyifangreeneyes
Copy link
Contributor Author

/test mysql-test tidb-test=pr/2114

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023
@xuyifangreeneyes
Copy link
Contributor Author

/test mysql-test tidb-test=pr/2114

1 similar comment
@xuyifangreeneyes
Copy link
Contributor Author

/test mysql-test tidb-test=pr/2114

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #42991.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #42992.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #42993.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42994.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@xuyifangreeneyes xuyifangreeneyes deleted the fix-load-stats branch April 12, 2023 11:59
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #42995.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42996.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #42997.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42998.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #42999.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #43000.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.0 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats loaded from json file have wrong status
4 participants