New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staistics: fix load stats from old version json | tidb-test=pr/2114 #42967
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/test mysql-test |
/test mysql-test tidb-test=pr/2114 |
/test mysql-test tidb-test=pr/2114 |
1 similar comment
/test mysql-test tidb-test=pr/2114 |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #42931
Problem Summary:
What is changed and how it works?
When v4.0.x and earlier versions dump stats json, stats json doesn't contain
StatsVer
. Before the PR, when we find stats json does not containStatsVer
, we just simply set itsStatsVer
to 1. Another fact is that we useStatsVer != 0
to decide whether stats are collected(i.e., analyze has been executed). SettingStatsVer
to 1 for stats json from old versions makes us unable to distinguish whether stats are collected or not. Hence, after the PR, when we find stats json does not containStatsVer
, we checkNDV > 0 || NullCount > 0
to decide whether stats are collected. If stats are collected, we set itsStatsVer
to 1, otherwise we set itsStatsVer
to 0.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.