Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the col resolution priority between outer scope and nature join folded col #43247

Merged
merged 1 commit into from Apr 26, 2023

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 20, 2023

What problem does this PR solve?

Issue Number: close #42912

Problem Summary:
a traditional name resolution priority problem as we talked before

image

for the cases, when building a where clause (1 !=((v0.c0)REGEXP(-7))), the resolution flow is:

  1. find the col in current p (built from natural join, only t0.c0 is remained, v0.c0 is folded)
  2. find the col in the outer layer scope, (for case 1, nothing here, find the col in step 3 (non-correlated); for case 2, find the col here (outer scope has exactly the same name v0.c0, Hops!) and return immediately (causing correlated))
  3. find the col in special cases, for example here, the current layer's nature-join col name folding

the sequence is not that right, we can simply move 3 forward 2 to make this right.

PS. Every outer scope layer should also think about nature-join folding, we didn't think about that as yet.

What is changed and how it works?

ref the last comment from issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the col resolution priority between outer scope and nature join folded col

…olded col

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fixdb
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2023
@AilinKid
Copy link
Contributor Author

/retest

Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2023
@fixdb
Copy link
Contributor

fixdb commented Apr 21, 2023

/retest

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2023
@winoros
Copy link
Member

winoros commented Apr 26, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 22eb830

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8b1e67f into pingcap:master Apr 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected result of subquery
4 participants