Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: disable non-prep plan cache for DML statements for now #43258

Merged
merged 3 commits into from Apr 20, 2023
Merged

planner: disable non-prep plan cache for DML statements for now #43258

merged 3 commits into from Apr 20, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 20, 2023

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: disable non-prep plan cache for DML statements for now

What is changed and how it works?

planner: disable non-prep plan cache for DML statements for now

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner April 20, 2023 13:02
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hawkingrei: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 20, 2023

/test unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 20, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bd38888

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@ti-chi-bot ti-chi-bot merged commit 78c50dc into pingcap:master Apr 20, 2023
8 checks passed
qw4990 added a commit to qw4990/tidb that referenced this pull request Apr 21, 2023
@qw4990
planner: disable non-prep plan cache for DML statements for now (ping…
3aa4d02 
…cap#43258)

ref pingcap#36598
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2023
@qw4990
planner: disable non-prep plan cache for DML statements for now (#43258…
2dd5ea9 
…) (#43274)

ref #36598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@chrysan chrysan chrysan approved these changes

Assignees
No one assigned
Labels
epic/plan-cache release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qw4990 @ti-chi-bot @hawkingrei @cfzjywxk @chrysan