New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix float literals and binary literals #4365

Merged
merged 6 commits into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@breeswish
Member

breeswish commented Aug 29, 2017

  • Fix incorrect decimal for float literals (Fix #4296)
  • Fix incorrect flag & collate for binary string literals (Fix #4216)

@zz-jason @XuHuaiyu PTAL

@XuHuaiyu

LGTM

@breeswish breeswish merged commit 62c8d39 into master Aug 29, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@breeswish breeswish deleted the wenxuan/fix-float-literal-decimal branch Aug 29, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment