New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: ignore some ttlworker in the goleak #43857
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9474344
|
/review default |
Pull Request ReviewTitle
DescriptionPR aims to close Issue #43855 by preventing memory leaks related to ttlworker. Key Changes
Potential Problems
Fixing Suggestions
SummaryThis PR is an attempt to prevent memory leaks in the goleak package by ignoring some ttlworker functions. While there are no major issues found in the PR, it is recommended to include tests covering the new changes and double-check the issue number mentioned in the PR description. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #43855
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.