ddl: roll back txn before handling ErrEntryTooLarge (#43867) #43879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #43867
What problem does this PR solve?
Issue Number: close #43725
Problem Summary:
DDL will use the same transaction to complete the update of the schema (onCreateTables) and the update of the job status (updateDDLJob). When the latter reports
ErrEntryTooLarge
error, it does not roll back the schema update, but sets the job to canceled and commits, resulting in the illusion that the DDL failed but the schema was actually updated.What is changed and how it works?
ErrEntryTooLarge
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.